Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update misnamed variable #943

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Update misnamed variable #943

merged 8 commits into from
Apr 25, 2024

Conversation

taheralfayad
Copy link
Contributor

Found an error relating to the modern filetype pull request that was recently merged into dev. There was a variable that was undefined that was being referenced in the setAcceptType() function. The original goal would have been to type in file.fileType rather than just fileType.

@dmols dmols self-requested a review April 24, 2024 21:54
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacement files no longer limited to just xlsx, docx, and pptx. Works well, clear to merge.

@dmols dmols merged commit 98fb0da into dev Apr 25, 2024
2 checks passed
@dmols dmols deleted the issue/899-filetype branch April 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants