Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/2.1.0 #42

Merged
merged 55 commits into from
Jun 14, 2024
Merged

Dev/2.1.0 #42

merged 55 commits into from
Jun 14, 2024

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Apr 17, 2024 •
edited
Loading

  • Question Bank
  • Accessibility updates
  • TBA

DynieM and others added 30 commits September 1, 2023 15:22
@DynieM
added modal and aria descriptions to flipping pages
cbd478d
@DynieM
audiocontrol changes, install.yaml, keyboard instructions, and screan…
1003556 
…reader updates for choices
@DynieM
dialog/modal instructions and screen reader for switching pages
3fa8449
@DynieM
aria live alerts/notifications & keyboard function for moving between…
bb8a955 
… questions and answers
@DynieM
made page navigation arrows into buttons
a6e1753
@DynieM
fixed finish button and edited screenreader feature for switching pages
3d6b377
@cayb0rg
Update config
670eda5
@DynieM
fixed page buttons and instructions dialog
89744e0
@cayb0rg
Update bootstrap order
518d02b
@cayb0rg
Upgrade package version
55b073e
@cayb0rg
Update release-build.yml
36051f4
@cayb0rg
Update test.yml
5addb96
@cayb0rg
Update test.yml
a386117
@cayb0rg
Update release-build.yml
f5dea3f
@cayb0rg
Update tests
4dee8de
@DynieM
fixed tabindex issues
5f19fbf
@DynieM
added back assistiveAlert
f4e9a8e
@DynieM
screenreader says how many matches are left after a match is made
91d61d6
@dmols
Implemented question bank and added styling
6ac6a61
@dmols
added on-hover CSS and element centering + watch function for questio…
41af181 
…nBankVal
@DynieM
fixed undefined bug and added alert of how many matches are made afte…
2100782 
…r switching pages
@DynieM
removed comments made for debugging
4e870e8
@dmols
Added more css for dialog and replaced questionBankVal listener with …
3a0fc77 
…disabled attribute solution
@dmols
Updated test snapshots
4a9e119
@dmols
Added edge case protection for qb shuffle, test coverage, and lowered…
66a807d 
… test threshold
@dmols
Changed dialog button styling to fit the theme better
59a8dec
@dmols
Fixed color reference names
b07a4e6
@dmols
Swapped css selector names to snake-case and added extra condition to…
b5642ee 
… disable attribute for qb confirm
@dmols
Added placeholder for questionBankVal, input validation, and fixed ht…
b28c08a 
…ml syntax
@dmols
Added small updates to functionality and all requested style updates
0d5bfbf
dmols and others added 25 commits January 29, 2024 18:15
@dmols
Reverted changes to shuffle function name and testing
7f9e639
@dmols
Added test coverage for enableQuestionBank case
7cb142d
@dmols
cleaned up commented out css code
0130582
@dmols
very minor css change for disabled qb button
267c663
@dmols
Added style changes to qb button and dialog close button
8fb1fcf
@dmols
disabled gray-out when no word pairs exist
e7be004
@dmols
Simplified questionBankVal validation and added test coverage for fun…
2409284 
…ction
@dmols
Minor styling changes
5e17a2d
@dmols
Added safeguarding for older qsets
a4bc69b
@DynieM
fixed duplication error and added instructions for keyboard
6b64b52
@DynieM
ignored launch.json
edd4cbf
@DynieM
fixed whitespace and indentation
0122769
@DynieM
deleted .vscode/launch.json
8d87e86
@clpetersonucf
Merge pull request #41 from dmols/questionBank_functionality
6f5011e 
Implemented question bank
@clpetersonucf
Resolves yarn.lock merge conflict
b7d568c
@clpetersonucf
Renews lockfile; updates release-build to use correct version of acti…
feddd9f 
…ons/checkout
@clpetersonucf
Resolves merge conflicts with dev/2.1.0
0764715
@clpetersonucf
Merge pull request #39 from cayb0rg/issue/mwdk-upgrade
bff5801 
Issue/mwdk-upgrade
@clpetersonucf
Merge conflict resolution with dev/2.1.0 part 1
72a0a44
@DynieM
changed insert code to set and remove attribute, also added checks fo…
986b40a 
…r DOM elements
@DynieM
player.html fixed
aa42133
@DynieM
fixed last inert issue
d207875
@clpetersonucf
Fix indentation of accessibility metadata in install.yaml
0ce4715
@clpetersonucf
Adjusts test coverage thresholds in package json
49a3189
@clpetersonucf
Merge pull request #40 from DynieM/accessibility-edits
a53750a 
Accessibility edits
@dmols dmols self-requested a review June 12, 2024 21:33
dmols
dmols approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widget works great with the accessibility changes! Last I reviewed, my big concern was that the user wasn't aware of how many matches were left to make when a pairing was made, and that's since been addressed. The keyboard navigation is a lot smoother too. Fantastic work!

I did find that voiceover doesn't work incredibly well with other languages (as far as pronunciation goes) unless you explicitly tell it what language you're typing in. This can be seen when testing with the demo. Throwing it out there to see if it sounds like good idea for an accessibility feature, to tackle in the future!

@clpetersonucf clpetersonucf merged commit b4c2765 into master Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmols dmols dmols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clpetersonucf @dmols @DynieM @cayb0rg