Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroys Change Management Record when destroying Software Record. #373

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

scherztc
Copy link
Contributor

Fixes #336

@scherztc scherztc force-pushed the fix/change_record branch 2 times, most recently from 84cbcbf to ebe9cdb Compare June 21, 2024 18:39
@hortongn
Copy link
Member

@scherztc I think it would be worth updating this exiting SoftwareRecord delete test to verify that it deletes an attached change request with the software record:
https://github.com/uclibs/application_portfolio/blob/qa/spec/controllers/software_records_controller_spec.rb#L396-L401

@scherztc scherztc force-pushed the fix/change_record branch from ebe9cdb to 574fe28 Compare July 10, 2024 13:10
@scherztc
Copy link
Contributor Author

The Software Record delete test has been updated to account for the ChangeRequest.

Copy link
Member

@hortongn hortongn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scherztc You need an expect statement that verifies the change request has been deleted.

@scherztc scherztc force-pushed the fix/change_record branch from 574fe28 to 1c350d8 Compare July 12, 2024 14:21
@scherztc scherztc force-pushed the fix/change_record branch from 1c350d8 to 25a21b1 Compare July 12, 2024 14:24
@scherztc
Copy link
Contributor Author

@hortongn : Initially, I thought that the SoftwareRecord test was enough, since it wouldn't actually pass if our code was wrong. After your feedback, I added another test that also checks for the deletion of the ChangeRequest. It should be good, now.

Copy link
Member

@hortongn hortongn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scherztc Thanks for adding the test!

@hortongn hortongn merged commit a423a62 into qa Jul 15, 2024
4 checks passed
@hortongn hortongn deleted the fix/change_record branch July 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting software records with attached change requests throws an error
2 participants