Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare types in the correct order #256

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Declare types in the correct order #256

merged 3 commits into from
Jul 17, 2024

Conversation

FedericoAureliano
Copy link
Contributor

This is a fix for #255. Like the title says, we were previously not declaring types in the correct order and now we are.

The code essentially constructs a dependency graph and then iteratively prints types that have no dependencies that are yet to be printed.

This pull request also adds the test case from #255 to the CI.

@adwait
Copy link
Contributor

adwait commented Jul 4, 2024

Seems right to me. Cross-listing a prior PR for a similar (the same?) issue that I thought fixed it: #241

@FedericoAureliano FedericoAureliano merged commit 289628e into master Jul 17, 2024
1 of 2 checks passed
@FedericoAureliano FedericoAureliano deleted the fix-255 branch July 17, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants