New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): fast ws disconnect during new conn setup #900

Merged

janthurau merged 1 commit into ueberdosis:main from 0xb4lamx:fix/handling-ws-closing

Feb 19, 2025

Contributor

0xb4lamx commented Feb 11, 2025

Issue

the WS could be disconnect{ing/ed} during setUpNewConnection() which could lead to improper state.

connected hooks will be fired
- the followup disconnected event will never be fired... WS graceful close already triggered...
onClose callbacks defined outside/after createConnection() wont be triggered
- uncleaned status
emitting to a closed socket

PR includes

server/src/ClientConnection.ts

WS state check right before WS emit events and trigger of connected hooks
await connected hooks

packages/server/src/Connection.ts

fast return if WS is closed


          fix(server): fast ws disconnect handling during conn setup

f9671cb

janthurau approved these changes

View reviewed changes

Collaborator

janthurau left a comment

Thank you!

janthurau merged commit 6817b53 into ueberdosis:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet