Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Component hash updates, FV3_HRRR namelist changes #906

Conversation

mkavulich
Copy link
Collaborator

@mkavulich mkavulich commented Sep 7, 2023

DESCRIPTION OF CHANGES:

This is a multi-purpose PR, introducing updates related to CCPP physics, a few WE2E test changes that didn't make it into #871) and updating external hashes.

Updating component hashes

Physics updates

WE2E test changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

TESTS CONDUCTED:

Ran a large number of relevant tests on Hera, and Orion, all passed.

  • hera.intel
    • Fundamental tests
    • All tests using FV3_HRRR suite
  • orion.intel
    • Coverage tests, including updated custom_ESGgrid_SF_1p1km test.
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

This PR incorporates changes from #892 which will be closed, since these changes required a hash update anyway it made sense to combine to consolidate testing efforts.

Includes changes from PR #871, so that must be merged before this one.

DOCUMENTATION:

In progress.

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS:

Thanks to @MichaelLueken for letting me roll his hash update changes into this PR

Thanks to Tanya Smirnova (CIRES/NOAA-GSL) for her help in updating the FV3_HRRR namelist settings.

@mkavulich mkavulich changed the title Hash updates, FV3_HRRR namelist changes [develop] Component hash updates, FV3_HRRR namelist changes Sep 7, 2023
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkavulich - Thanks for updating the component hashes as part of your FV3_HRRR namelist changes! These changes look good to me!

I have gone ahead and run the fundamental tests on Hera:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta    COMPLETE               8.24
nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_  COMPLETE              11.31
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2        COMPLETE               6.62
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              12.52
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR          COMPLETE              25.19
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0              COMPLETE              12.96
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16                COMPLETE              18.77
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              95.61

as well as the aqm_grid_AQM_NA13km_suite_GFS_v16 test, which also successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16                                  COMPLETE            1039.44
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1039.44

Approving this work now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Sep 12, 2023
@MichaelLueken
Copy link
Collaborator

Manual run of the WE2E coverage tests on Hera Intel all successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
custom_ESGgrid_Central_Asia_3km                                    COMPLETE              23.50
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200          COMPLETE               6.33
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2  COMPLETE             746.78
get_from_HPSS_ics_HRRR_lbcs_RAP                                    COMPLETE              13.31
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2        COMPLETE               5.63
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot     COMPLETE              12.22
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP                 COMPLETE               9.47
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2        COMPLETE               6.47
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2         COMPLETE             226.55
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16           COMPLETE             294.79
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR            COMPLETE             323.57
pregen_grid_orog_sfc_climo                                         COMPLETE               7.53
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1676.15

@MichaelLueken
Copy link
Collaborator

The manual testing of Hera GNU WE2E coverage tests has successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
custom_ESGgrid_Peru_12km                                           COMPLETE              30.56
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2019061200         COMPLETE              18.75
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS                             COMPLETE              32.63
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR             COMPLETE             235.61
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta      COMPLETE              35.87
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0              COMPLETE              22.99
long_fcst                                                          COMPLETE              75.42
MET_verification_only_vx                                           COMPLETE               0.13
MET_ensemble_verification_only_vx_time_lag                         COMPLETE               7.58
nco_grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16      COMPLETE             344.11
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             803.65

Once the current reruns of Gaea and Jet successfully pass, this work can be merged.

@MichaelLueken
Copy link
Collaborator

The Jenkins tests have successfully passed on both Gaea:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
community                                                          COMPLETE              22.28
custom_ESGgrid_NewZealand_3km                                      COMPLETE              64.85
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta    COMPLETE              29.80
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP              COMPLETE              32.96
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR             COMPLETE              34.33
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             367.42
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR          COMPLETE              34.29
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta     COMPLETE             351.24
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot      COMPLETE              10.99
nco_ensemble                                                       COMPLETE              86.17
nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thom  COMPLETE             365.02
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1399.35

and Jet:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
community                                                          COMPLETE              19.74
custom_ESGgrid                                                     COMPLETE              17.84
custom_ESGgrid_Great_Lakes_snow_8km                                COMPLETE              13.76
custom_GFDLgrid                                                    COMPLETE               9.66
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2021032018         COMPLETE              13.99
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_netcdf_2022060112_48h     COMPLETE              58.02
get_from_HPSS_ics_RAP_lbcs_RAP                                     COMPLETE              17.71
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR                 COMPLETE             262.59
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot     COMPLETE              42.34
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2        COMPLETE               8.03
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta       COMPLETE             639.59
nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR       COMPLETE              11.20
process_obs                                                        COMPLETE               0.45
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1114.92

Moving forward with merging this PR now.

@MichaelLueken MichaelLueken merged commit 95e4d84 into ufs-community:develop Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GST_release_public_v1 test fails on Hera in latest develop Update FV3_HRRR suite for latest RRFS development
3 participants