Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change references from "nems" to "ufs", allow file clobbering for GOCART history files #1948

Closed
wants to merge 19 commits into from
Closed

change references from "nems" to "ufs", allow file clobbering for GOCART history files #1948

wants to merge 19 commits into from

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Oct 18, 2023 •
edited
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Updates instances of nems to be ufs in scripts. Updates CMEPS to use better terms for describing UFS coupling modes.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Oct 18, 2023
@DeniseWorthen DeniseWorthen marked this pull request as ready for review October 18, 2023 17:13
@DeniseWorthen DeniseWorthen mentioned this pull request Oct 18, 2023
Merged
42 tasks
@DeniseWorthen DeniseWorthen mentioned this pull request Oct 20, 2023
Closed
@DeniseWorthen DeniseWorthen added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Oct 23, 2023
@DeniseWorthen DeniseWorthen changed the title change references from "nems" to "ufs" change references from "nems" to "ufs", allow file clobbering for GOCART history files Oct 24, 2023
@zach1221 zach1221 mentioned this pull request Oct 30, 2023
Merged
42 tasks
jkbk2004 pushed a commit that referenced this pull request Oct 31, 2023
@DusanJovic-NOAA
Add zstandard compression to fv3atm; change references from "nems" to…
ce6c046 
… "ufs", allow file clobbering for GOCART history files (was #1948) (#1932)

* Enable zstd compression in several tests

* update FD and some nems configs

* all except lnd sbs run

* update aero_history to allow file clobber
@jkbk2004
Copy link
Collaborator

merged with #1932

@jkbk2004 jkbk2004 closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA left review comments

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa

Assignees
No one assigned
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix file clobbering issue with GOCART history files use ufs-appropriate named files and executables
3 participants
@DeniseWorthen @jkbk2004 @BrianCurtis-NOAA