Third reconciliation PR from production/RRFS.v1 #2482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This is mainly work from @AndersJensen-NOAA. This PR is identical to #2161, but targets develop instead of the RRFSv1 release branch.
This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.
This PR includes:
The addition of parameterized kind: REAL -> real(kind_phys)
Consistent indentation
Removal of GOTO statements
Add physical constant metadata needed by Thompson MP
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
All tests that use Thompson MP will have non bit-for-bit results due to high significant digit changes in physical constants. There is no substantial change in results as tested by @AndersJensen-NOAA in #2161.
Input data Changes:
Library Changes/Upgrades:
Testing Log: