-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time-averaged radiation computation #2553
base: develop
Are you sure you want to change the base?
Fix time-averaged radiation computation #2553
Conversation
Full suite of regression tests completed on Hera. All tests with surface files checked fail as expected. |
@LarissaReames-NOAA do you still keep your regression test on hera? so we can push test_changes.list and test log. |
@LarissaReames-NOAA can you sync up branches? |
Apologies, I'm having trouble getting my RT runs to all execute without failure on Hera. Both rocoto and ecflow both have shell hangups causing the runs to fail. I'm working on debugging this and will push test_changes.list and merge develop as soon as I have that issues resolved. |
Do you have any issue w/ running RTs on hercules or orion? |
@jkbk2004 RT long and test_changes.list have been added and I've merged the top of develop. |
Commit Queue Requirements:
Description:
This PR fixes incorrect diagnostic output for fhzero-averaged radiation output variables. Presently, there is a significant "sawtooth" appearance to these fields (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) from a 24-hour S2S regression test forecast.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: