Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge NCAR:main to ufs-community:ufs/dev (ccpp/physics) + update GF/C3 for SRW3.0 release #2601

Merged
merged 18 commits into from
Feb 14, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 11, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates the ufs-community:ufs/dev branch of ccpp-physics from the NCAR:main. See ufs-community/ccpp-physics#251 for a more complete description of the ccpp-physics changes. The documentation changes included therein are needed for the SRW App v3.0 release.

Combined with #2576 from @haiqinli. His description is as follows:
Update the GF/C3 for the SRW 3.0.0 release. It includes some of the GF/C3 updates implemented for RRFSv1 and still was successful in reproducing predicted severe storms. It also includes the simplified cold pool parameterization for C3.

Commit Message:

* UFSWM - updates to ccpp-physics docs, nTiedtke deep convection, CCPP scheme simulator and other minor changes + update GF/C3 for SRW3.0 release
  * FV3 - updates to ccpp-physics docs, nTiedtke deep convection, CCPP scheme simulator and other minor changes + update GF/C3 for SRW3.0 release
    * ccpp-physics - updates to ccpp-physics docs, nTiedtke deep convection, CCPP scheme simulator and other minor changes + update GF/C3 for SRW3.0 release

Priority:

  • High: Needed for SRW App v3.0 release

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl grantfirl mentioned this pull request Feb 12, 2025
15 tasks
@grantfirl
Copy link
Collaborator Author

@jkbk2004 OK, the combination is finished. I kept the test_changes.list and the hera pre-test log from #2576. I'll update the PR descriptions to reflect the combination, but the code should be ready to test.

@grantfirl grantfirl changed the title Merge NCAR:main to ufs-community:ufs/dev (ccpp/physics) Merge NCAR:main to ufs-community:ufs/dev (ccpp/physics) + update GF/C3 for SRW3.0 release Feb 12, 2025
@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Feb 12, 2025
@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA @FernandoAndrade-NOAA This PR is ready.

@jkbk2004 jkbk2004 added the jenkins-ort run ORT testing label Feb 13, 2025
@jkbk2004 jkbk2004 removed the jenkins-ort run ORT testing label Feb 14, 2025
@jkbk2004
Copy link
Collaborator

We can start merging process.

@jkbk2004
Copy link
Collaborator

@grantfirl new fv3 hash is NOAA-EMC/fv3atm@b1e4667

@jkbk2004 jkbk2004 merged commit 443df8e into ufs-community:develop Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants