Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54 add tests for check shibboleth #55

Merged
merged 2 commits into from
Feb 5, 2024
Merged

54 add tests for check shibboleth #55

merged 2 commits into from
Feb 5, 2024

Conversation

philsmart
Copy link
Member

No description provided.

@philsmart philsmart linked an issue Jan 18, 2024 that may be closed by this pull request
Add tests for check_shibboleth #54
Closed
@philsmart philsmart requested review from iay and alexstuart January 19, 2024 09:46
@alexstuart
Copy link
Member

Good catch of the 2 tests that need changing.

Can you change the XSL so the different predicates are clearer? Something like this:

    <xsl:template match="md:SPSSODescriptor
        [contains(@protocolSupportEnumeration, 'urn:oasis:names:tc:SAML:2.0:protocol')]
        [md:NameIDFormat]
        [not(
          (md:NameIDFormat[.='urn:oasis:names:tc:SAML:2.0:nameid-format:persistent']) or 
          (md:NameIDFormat[.='urn:oasis:names:tc:SAML:2.0:nameid-format:transient'])
        )]">

@philsmart
Copy link
Member Author

Sounds good. I will.

@philsmart philsmart force-pushed the 54-add-tests-for-check_shibboleth branch from ffc0cd7 to cdd0c64 Compare January 22, 2024 17:09
@philsmart
Copy link
Member Author

That should be done for those predicates

iay
iay approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@iay iay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@philsmart philsmart merged commit 990521d into main Feb 5, 2024
1 check passed
@iay iay deleted the 54-add-tests-for-check_shibboleth branch June 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iay iay iay approved these changes

@alexstuart alexstuart Awaiting requested review from alexstuart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for check_shibboleth
3 participants
@philsmart @alexstuart @iay