Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support option overrides and test skipping #80

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Support option overrides and test skipping #80

merged 4 commits into from
Feb 26, 2024

Conversation

iay
Copy link
Member

@iay iay commented Feb 22, 2024

WIP:

  • Reworked README to be clearer, and add documentation for overrides.
  • Supports option overrides in general based on endpoint name matching.
  • Supports skip: true.

@iay iay requested a review from philsmart February 22, 2024 17:54
@iay iay self-assigned this Feb 23, 2024
@iay iay marked this pull request as ready for review February 23, 2024 12:09
@iay iay requested a review from alexstuart February 23, 2024 12:09
@alexstuart
Copy link
Member

alexstuart commented Feb 23, 2024

I like this a lot & approve (in both senses of the word).

Two nits:

  1. line 57 you typoed "imlementing"

  2. lines 60-62 you write

v09x represents the current production deployment. Its name reflects that environment's composition: v0.9.x of the Shibboleth Metadata Aggregator, and the Xalan XSL processor included in the classpath.

You're using using x to signify "with Xalan" and also "a patch version". Might be clearer if you don't add the patch version.

@iay
Copy link
Member Author

iay commented Feb 23, 2024

v09x represents the current production deployment. Its name reflects that environment's composition: v0.9.x of the Shibboleth Metadata Aggregator, and the Xalan XSL processor included in the classpath.

You're using using x to signify "with Xalan" and also "a patch version". Might be clearer if you don't add the patch version.

Oh, good catch. I will just say v0.9 in this case, and fix up the other thing. Cheers.

@iay
Copy link
Member Author

iay commented Feb 23, 2024

Pushed another commit to fix those issues. I'll squash it into one of the others before merging.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@iay iay merged commit e910b7f into main Feb 26, 2024
1 check passed
@iay iay deleted the overrides branch February 26, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants