Skip to content

Commit

Permalink
KIM Integration - provisioner client removed from runtime reconciler (
Browse files Browse the repository at this point in the history
kyma-project#1123)

* provisioner client removed

* linter

---------

Co-authored-by: Piotr Miśkiewicz <[email protected]>
  • Loading branch information
jaroslaw-pieszka and piotrmiskiewicz authored Sep 12, 2024
1 parent b0dfd5a commit 8408e12
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
5 changes: 1 addition & 4 deletions cmd/runtimereconciler/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
btpmanager "github.com/kyma-project/kyma-environment-broker/internal/btpmanager/credentials"
"github.com/kyma-project/kyma-environment-broker/internal/events"
"github.com/kyma-project/kyma-environment-broker/internal/process/input"
"github.com/kyma-project/kyma-environment-broker/internal/provisioner"
"github.com/kyma-project/kyma-environment-broker/internal/storage"
"github.com/sirupsen/logrus"
"github.com/vrischmann/envconfig"
Expand Down Expand Up @@ -61,9 +60,7 @@ func main() {
kcpK8sClient, err := client.New(kcpK8sConfig, client.Options{})
fatalOnError(err, logs)

provisionerClient := provisioner.NewProvisionerClient(cfg.Provisioner.URL, false, logs.WithField("service", "provisioner"))

btpOperatorManager := btpmanager.NewManager(ctx, kcpK8sClient, db.Instances(), logs, cfg.DryRun, provisionerClient)
btpOperatorManager := btpmanager.NewManager(ctx, kcpK8sClient, db.Instances(), logs, cfg.DryRun)

logs.Infof("job enabled? %t", cfg.JobEnabled)
if cfg.JobEnabled {
Expand Down
5 changes: 1 addition & 4 deletions internal/btpmanager/credentials/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"github.com/kyma-project/kyma-environment-broker/internal/kubeconfig"

"github.com/kyma-project/kyma-environment-broker/internal"
"github.com/kyma-project/kyma-environment-broker/internal/provisioner"
"github.com/kyma-project/kyma-environment-broker/internal/storage"
"github.com/kyma-project/kyma-environment-broker/internal/storage/dbmodel"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -58,18 +57,16 @@ type Manager struct {
instances storage.Instances
kcpK8sClient client.Client
dryRun bool
provisioner provisioner.Client
k8sClientProvider K8sClientProvider
logger *logrus.Logger
}

func NewManager(ctx context.Context, kcpK8sClient client.Client, instanceDb storage.Instances, logs *logrus.Logger, dryRun bool, provisioner provisioner.Client) *Manager {
func NewManager(ctx context.Context, kcpK8sClient client.Client, instanceDb storage.Instances, logs *logrus.Logger, dryRun bool) *Manager {
return &Manager{
ctx: ctx,
instances: instanceDb,
kcpK8sClient: kcpK8sClient,
dryRun: dryRun,
provisioner: provisioner,
logger: logs,
k8sClientProvider: kubeconfig.NewK8sClientFromSecretProvider(kcpK8sClient),
}
Expand Down
3 changes: 1 addition & 2 deletions internal/btpmanager/credentials/manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (

uuid2 "github.com/google/uuid"
"github.com/kyma-project/kyma-environment-broker/internal"
"github.com/kyma-project/kyma-environment-broker/internal/provisioner"
"github.com/kyma-project/kyma-environment-broker/internal/storage"
"github.com/kyma-project/kyma-environment-broker/internal/storage/dbmodel"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -66,7 +65,7 @@ func InitEnvironment(ctx context.Context, t *testing.T) *Environment {
}

newEnvironment.createTestData()
newEnvironment.manager = NewManager(ctx, newEnvironment.kcp, newEnvironment.kebDb.Instances(), logs, false, provisioner.NewFakeClient())
newEnvironment.manager = NewManager(ctx, newEnvironment.kcp, newEnvironment.kebDb.Instances(), logs, false)
newEnvironment.job = NewJob(newEnvironment.manager, logs)
newEnvironment.assertThatCorrectNumberOfInstancesExists()
return newEnvironment
Expand Down

0 comments on commit 8408e12

Please sign in to comment.