Feature/tss-1064-display-related-barriers #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/uktrade/market-access-api into feature/TSS-1064-display-related-barriers
osimuka
requested review from
ferozerub,
Santino-Trade and
chris-pettinga
and removed request for
ferozerub and
Santino-Trade
…ithub.com/uktrade/market-access-api into feature/TSS-1064-display-related-barriers
…ithub.com/uktrade/market-access-api into feature/TSS-1064-display-related-barriers
…-barriers' into feature/TSS-1064-display-related-barriers
* moving ML requirements to another file and seeing if that fixes deployment * fixed Procfile * moving collectstatic to Procfile * Added numpy to requirements-related-barriers.txt * moving stuff to .profile * updating .profile * updating .profile * adding shell to .profile and changing Dockerfile to install the new requirements file * removing activation of virtualenv * moving import statement to make debugging easier * isntalling sentence-transofmrers directly in the .profile without deps and explicitly installing cpu-only torch * removing tmpdir, no neeed for it now * Revert "removing tmpdir, no neeed for it now" This reverts commit faa8690. * updated dockerfile * playing around with removing additional requirements-related-barriers.txt * added the good stuff to dev dependencies so removed from Dockerfile. Now only good stuff is in deployment .profile * updating Dockerfile for no change * reorganising imports * adding comments * removing collectstatic * readdding collectstatic
…ame not a queryset. (#680) Similarity score now - as part of this dataframe - gets passed to the serializer for response. Removed caching as we want to test quickly and will be fixed as part of a different ticket
|
Can we add some unit tests to test the view works and some to test |
Yes we can add tests, since its an ML functionality, the main tests will be mocked data and making sure functions are being called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.