Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove audio modules in favor of playerctl #2231

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

lasers
Copy link
Contributor

@lasers lasers commented Jan 20, 2024

This remove clementine, gpmdp, and player_control in favor of playerctl .

clementine

  • IIRC, code have mpris-1/mpris-2 issue. Also, old.
  • New module from scratch if implemented again.
  • Only one placeholder. Use playerctl instead.

gpmdp

  • Deprecated. Link doesn't work too.
  • Google's current solution might be to use Chrome to make and use Youtube app shortcut instead.
  • Run extra remote-cmd calls every time based on number of placeholders.
  • No longer available on many distributions. Use playerctl instead.

player_control

  • Designed specifically for two players only.
  • Lot of old and simple code. No py3 helpers.
  • Only one placeholder {icon}. Use playerctrl instead.

mpris and spotify probably still have some users.

/cc @jdholtz, author of playerctl

@ultrabug ultrabug merged commit 4b7148f into ultrabug:master Jan 22, 2024
5 checks passed
@ultrabug
Copy link
Owner

Fair enough, thanks

@lasers lasers deleted the deprecate-modules branch January 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants