external_script module: allow scripts to specify urgent #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasers
reviewed
Jan 19, 2025
|
Thanks to you both for your contribution and iteration on ideas! |
|
Uhhh, I was just about to upload the revised code... I'll open a new PR for it. |
|
@devkev then I read lasers conclusion too fast I'm sorry, thx |
|
No worries. New PR is #2283, the code is as we discussed above, the documentation hasn't been reviewed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a need for an external script to specify not just the output color, but also whether or not the output should be "urgent".