Support the new Unity Input System #1676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgrading and also Unity's solution to build a map of materials to upgrade / downgrade between BiRP and URP
… render pipeline for all ultraleap materials in packages and samples/examples. Untested
…Added and assigned clones of the default materials that can be upgraded. Also attempting to improve the glass material appearance on conversion to URP
…erials and shader folders - to be consistent and contain Univeral Render Pipeline and Built In Render Pipeline subfolders
…erials and shader folders - to be consistent and contain Univeral Render Pipeline and Built In Render Pipeline subfolders. This time for samples
…t present - e.g. with BiRP. See �[200~https://discussions.unity.com/t/package-requirements-in-shaderlab/840638~
…hipped by Ultraleap
…is will only be asked once - although that state is currently persisted and needs a better mechanism
Add missing Unity UI dependency to preview package
…erialized instance). Now logs materials that could not be converted
…ps://github.com/ultraleap/UnityPlugin into feature/support_URP_and_BiRP_in_assets_XRFE-182
Cleaned up commented code and comments
Added a space to the prompt.
…ps://github.com/ultraleap/UnityPlugin into feature/support_URP_and_BiRP_in_assets_XRFE-182
…in_assets_XRFE-182 Support URP and BiRP including for Unity 6
This script is only used in the Editor, so this is the correct way to handle input listening and will work no matter the input system that's currently in use.
Update Copyright year and fix formatting
This script is only used in the Editor, so this is the correct way to handle input listening and will work no matter the input system that's currently in use.
…o use the new Input System UIInput Module
…mples and examples that use the (old) Unity Input Manager
…te does not change to On if toggled to the on state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ensures that all the parts of the main Ultraleap Tracking package support the new Unity Input System.
Only the
UIInputModulein the Tracking Preview package and the controller example for the input manager does not work with this system. These have been split into a set of examples for the input manager (old) from the existing tracking preview examples which are now the main examples. There is also a common set of example assets that need to be imported for both example 'packages' to work.While splitting/moving the examples, a couple of issue have been fixed with the UI input scene
Contributor Tasks
Test Cycle
Link to the test cycle here.
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.mdinstead of using the link. See query parameter docs for more information.