Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_domains.yml #129

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update check_domains.yml #129

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced the GitHub Actions workflow to improve notification handling for failed domain checks.

πŸ“Š Key Changes

  • Updated Slack Action: Migrated from slackapi/[email protected] to v2.0.0.
  • Configuration Tweaks: Adjusted Slack notification setup for better reliability and clarity.

🎯 Purpose & Impact

  • Improved Notification Mechanism: By updating the Slack action version, the workflow adopts a more modern and supported method for sending notifications, which should be more robust and easier to maintain.
  • Streamlined Workflow: The revised setup aims to ensure prompt and clear communication of errors, helping maintainers quickly address any issues with domain checks. πŸš€

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/docs πŸš€ PR! This is an automated response to help streamline your PR review process. An Ultralytics engineer will assist you shortly. In the meantime, please review the following checklist to help ensure a seamless integration of your work:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is up-to-date with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Ensure your changes are limited to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For additional guidance, feel free to refer to our Contributing Guide. If you have any questions or need further assistance, don’t hesitate to leave a comment. Thank you for contributing to Ultralytics! πŸŽ‰

@glenn-jocher glenn-jocher merged commit 8054931 into main Nov 19, 2024
2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants