Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_domains.yml #131

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update check_domains.yml #131

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

@sergiuwaxmann added the updated domains here.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancements to domain checks in the GitHub workflow added new domains and corrected typos.

πŸ“Š Key Changes

  • Added new domains such as "ultralytics.co", "ultralytics.us", and "ultralytics.dev".
  • Included common misspellings of "Ultralytics" to ensure those domains are checked.
  • Organized existing domain list and added a comment to clarify inclusion of "yolov5.com" and similar domains.

🎯 Purpose & Impact

  • πŸ•΅οΈβ€β™‚οΈ Improves the robustness of domain monitoring by covering possible variants and misspellings.
  • 🌐 Enhances brand protection and intellectual property oversight by ensuring all relevant domains are continuously checked.
  • πŸ’ͺ Provides clarity and better maintainability in domain management procedures.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for your contribution to the ultralytics/docs πŸš€ repository! This is an automated response, and an Ultralytics engineer will review your changes shortly. In the meantime, please ensure the following checklist items are completed to help us expedite the process:

  • βœ… Define a Purpose: Ensure your PR clearly states its purpose and links to any relevant issues. Make sure your commit messages are clear and adhere to the project's conventions.
  • βœ… Synchronize with Source: Double-check that your PR syncs with the latest main branch of ultralytics/docs. If it is not up-to-date, you can update it using the 'Update branch' button or by executing git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Confirm all Ultralytics Continuous Integration (CI) checks are passing. If there are any failures, please resolve them.
  • βœ… Update Documentation: Reflect any new or altered features in the appropriate documentation.
  • βœ… Add Tests: Where applicable, ensure tests are added or updated to encompass your changes, and that all tests pass successfully.
  • βœ… Sign the CLA: If this is your first contribution to Ultralytics, please ensure you've signed our Contributor License Agreement by stating "I have read the CLA Document and I sign the CLA" in a new comment.
  • βœ… Minimize Changes: Restrict your changes to only those necessary for your bug fix or feature addition. 🧘 "It is not daily increase but daily decrease, hack away at the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For further information, refer to our Contributing Guide. Feel free to reach out in the comments if you have any questions. Thanks again for enhancing our documentation with your efforts! πŸŽ‰

@glenn-jocher glenn-jocher merged commit adfd56a into main Nov 19, 2024
2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants