Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_domains.yml #132

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update check_domains.yml #132

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Simplified and cleaned up the domain list in the GitHub workflow script.

πŸ“Š Key Changes

  • Removed comment tags for the misspelled and related domains in the domain list within the check_domains.yml file.

🎯 Purpose & Impact

  • 🧹 Purpose: Enhance code clarity and reduce clutter by removing unnecessary comments, making the workflow script cleaner and easier to maintain.
  • πŸ“ˆ Impact: Improves the readability of the code for developers, aiding in easier management and updates in the future without impacting the functional behavior of the workflow.

@glenn-jocher glenn-jocher merged commit b6e99d4 into main Nov 19, 2024
1 of 2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 20:24
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/docs πŸš€ PR! This is an automated response to guide you through our PR review process, and an Ultralytics engineer will also assist you soon.

To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your changes in the PR description and link to any relevant issues. Make sure your commit messages are clear, concise, and follow the project's conventions.
  • βœ… Synchronize with Source: Confirm that your PR is synchronized with the ultralytics/docs main branch. If it's behind, you can update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify that all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update any relevant documentation for new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and ensure that all tests are passing.
  • βœ… Sign the CLA: Please make sure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Ensure your changes are the minimum necessary for your bug fix or feature addition. As Bruce Lee said, β€œIt is not daily increase but daily decrease, hack away the unessential.”

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for enhancing our documentation! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants