Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return [TIMEOUT] lines #145

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Return [TIMEOUT] lines #145

merged 1 commit into from
Jan 5, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 5, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved processing of link-check summaries in GitHub workflows by enhancing escape handling and filtering.

πŸ“Š Key Changes

  • Improved the script to skip lines starting with [TIMEOUT] in the summary preparation for Slack messages.
  • Enhanced escape sequence handling in the summary for better formatting (e.g., removing brackets, .html, and escaping quotes).

🎯 Purpose & Impact

  • πŸ› οΈ Purpose: To clean up and refine summaries sent to Slack, ensuring they are more readable and removing unnecessary content such as [TIMEOUT] lines.
  • 🌟 Impact: Improves clarity and formatting of automated notifications, making them easier for users to read and act upon. This leads to more streamlined communication.

Signed-off-by: Glenn Jocher <[email protected]>
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 5, 2025 3:15pm

@glenn-jocher glenn-jocher changed the title Update links.yml Return [TIMEOUT] lines Jan 5, 2025
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 5, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/docs πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your update. β€œSimplicity is the ultimate sophistication.” β€” Leonardo da Vinci

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions.

This is an automated response to assist you in aligning with our contribution guidelines. Rest assured, an Ultralytics engineer will review and provide further feedback soon. Thank you for contributing to Ultralytics! πŸš€

@glenn-jocher glenn-jocher merged commit 2d0580e into main Jan 5, 2025
4 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 5, 2025 15:16
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Your PR has been merged, @glenn-jocher!

Thank you for your thoughtful improvements to the link-check summaries! Your enhancements to escape handling and filtering will make communication clearer and more efficient for everyone. πŸš€

As Leonardo da Vinci once said, β€œSimplicity is the ultimate sophistication.” Your efforts to declutter and refine the detail in Slack notifications are a testament to that wisdom, and they will undoubtedly elevate the experience for all who rely on this workflow.

We appreciate your dedication and impactful contributions. Keep shining! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants