Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commet duplicated ESCAPED_SUMMARY #148

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 8, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated a GitHub Actions workflow for cleaning up Slack summaries by removing a filtering rule.

πŸ“Š Key Changes

  • Modified the workflow script in links.yml to no longer exclude lines starting with [TIMEOUT] when preparing Slack notifications.

🎯 Purpose & Impact

  • Purpose: Ensures all lines from summary.txt, including those starting with [TIMEOUT], are included in Slack notifications.
  • Impact: Provides more complete and transparent notification summaries, potentially helping teams identify and act on issues flagged as [TIMEOUT]. πŸš€

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 8, 2025 10:53am

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 8, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/docs πŸš€ PR! To ensure a smooth review and integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and follow the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If your branch is behind, please update it by clicking the 'Update branch' button or using git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Continuous Integration (CI) checks are passing. If any checks fail, make the necessary fixes.
  • βœ… Update Documentation: Update the relevant documentation to reflect any significant changes or new behaviors introduced by your PR.
  • βœ… Add Tests: If applicable, ensure that appropriate tests are added or updated and confirm all tests are passing.
  • βœ… Sign the CLA: If this is your first contribution to Ultralytics, please ensure you have completed our Contributor License Agreement (CLA). Sign the CLA by commenting: "I have read the CLA Document and I sign the CLA."
  • βœ… Minimize Changes: Keep your changes concise and focused. Aim for simplicity and clarity. "Simplicity is the ultimate sophistication." β€” Leonardo da Vinci

πŸ”Ž Review Notes for Your PR:
From the provided description and diffs:

  • Great job simplifying the Slack summary logic πŸŽ‰! Your updates seem like a meaningful improvement for workflow clarity.
  • If applicable, kindly verify any downstream effects this change might have, such as on other GitHub Actions within the repository.
  • Don't forget to test your workflow modifications via the provided CI jobs or debug directly in your forks using test runs.

For additional details, please refer to our Contributing Guide. An Ultralytics engineer will review this soon and provide further feedback if needed. Thank you for contributing to Ultralytics! πŸ™ŒπŸš€

@glenn-jocher glenn-jocher merged commit 694425a into main Jan 8, 2025
4 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 8, 2025 10:55
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Exciting news, @glenn-jocherβ€”your PR has been merged! πŸ™Œ Thank you for refining our Slack workflow to embrace transparency and completeness. Your thoughtful attention to detail ensures that every [TIMEOUT] now gets its deserved spotlight. πŸš€

As Leonardo da Vinci once said, "Details make perfection, and perfection is not a detail." Your contribution exemplifies this, and it's clear that these small changes will have a meaningful impact on collaboration and problem-solving.

Keep shining and thank you for helping us move forward together! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants