Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-retry.yml #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update test-retry.yml #136

wants to merge 1 commit into from

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 25, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement of the GitHub test workflow with a more flexible configuration for retries.

πŸ“Š Key Changes

  • Added a shell: python configuration to the retry action, allowing Python commands to be retried.
  • Incorporated a retry_delay parameter of 5 seconds for immediate retry logic, and a 30 seconds delay for longer retries.
  • Modified the test command to simulate a failure by using print(1/0) for better testing of the retry mechanism.

🎯 Purpose & Impact

  • Enhanced Flexibility: By allowing Python commands and configurable retry delays, the workflow is more adaptable to different testing needs. πŸ“ˆ
  • Better Testing Simulation: Simulating a failure with print(1/0) helps ensure the retry mechanism is robust and working as intended, improving overall reliability. πŸš€
  • User Impact: Users benefit from more reliable CI pipelines, ensuring that transient issues don't cause unnecessary build failures. β˜‘οΈ

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Oct 25, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting this PR to the ultralytics/velocity repository! πŸš€ This is an automated response, but rest assured, an Ultralytics engineer will review your contribution soon. In the meantime, please take a moment to ensure everything is in order:

  • βœ… Define a Purpose: Clearly explain the purpose of your changes in the description, and link to any related issues if applicable. Detailed commit messages help us understand the context better.
  • βœ… Synchronize with Source: Make sure your branch is up-to-date with main. You can click β€˜Update branch’ or run git pull and git merge main to sync locally.
  • βœ… Ensure CI Checks Pass: All Continuous Integration (CI) checks should pass. Please address any failed checks to ensure smooth merging.
  • βœ… Update Documentation: If you've introduced new features or changes, please update the related documentation so users can understand and benefit from your improvements.
  • βœ… Add Tests: If relevant, include or update tests to cover your modifications, and verify that all tests are passing successfully.
  • βœ… Sign the CLA: If this is your first contribution to Ultralytics, sign our Contributor License Agreement (CLA). Add "I have read the CLA Document and I sign the CLA" in a new comment to confirm.
  • βœ… Minimize Changes: Focus your changes on the essential fixes or feature enhancements. Remember what Bruce Lee said, "Hack away the unessential." βœ‚οΈ

For more detailed instructions, please check our Contributing Guide. Feel free to ask any questions here, and thank you for helping make Ultralytics better! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants