Skip to content

Commit

Permalink
Prevent sending duplicate reaction events (#240)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kladki authored Apr 2, 2024
1 parent 72d3543 commit aba72aa
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
16 changes: 16 additions & 0 deletions src/base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,22 @@ impl RoomInfo {

return top;
}

/// Checks if a given user has reacted with the given emoji on the given event
pub fn user_reactions_contains(
&mut self,
user_id: &UserId,
event_id: &EventId,
emoji: &str,
) -> bool {
if let Some(reactions) = self.reactions.get(event_id) {
reactions
.values()
.any(|(annotation, user)| annotation == emoji && user == user_id)
} else {
false
}
}
}

/// Generate a [CompletionMap] for Emoji shortcodes.
Expand Down
7 changes: 7 additions & 0 deletions src/windows/room/chat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,13 @@ impl ChatState {
},
};

if info.user_reactions_contains(&settings.profile.user_id, &event_id, &emoji) {
let msg = format!("You’ve already reacted to this message with {}", emoji);
let err = UIError::Failure(msg);

return Err(err);
}

let reaction = Annotation::new(event_id, emoji);
let msg = ReactionEventContent::new(reaction);
let _ = room.send(msg).await.map_err(IambError::from)?;
Expand Down

0 comments on commit aba72aa

Please sign in to comment.