Fix image preview in replies and threads #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was necessary to break out `Message::show_msg` from `MessageFormatter::push_in_reply`, due to the lifetime of the image protocol. `Message::show_with_preview` now returns the image protocols of both the body and reply header. `Scrollback::render` was updated to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is a fix for #362
The root cause was that the image protocol from a reply header was being ignored.
An image in a reply header is now handled in the same way as an image in the body of the message, with the image position offsets modified to account for the difference in formatting (vertical lines, indent, etc).
It was necessary to break out
Message::show_msgfromMessageFormatter::push_in_replydue to the lifetime of the image protocol.Message::show_with_previewnow returns the image protocols of both the body and the reply header.Scrollback::renderwas updated to handle this.