-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our Umbraco: High five feed #277
Open
crgrieve
wants to merge
80
commits into
umbraco:main
Choose a base branch
from
crgrieve:temp-high-five
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs work for responsive styling
…laying most recent high fives, with a mock API response.
… into temp-high-five
… into temp-high-five
… into temp-high-five
…ionality as those libraries exist already on Our.Umbraco.
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
… into temp-high-five
…dating on form submit.
hopefully more efficient :)
… required, which is great for accessibility.
…for url input, add more compliments from retreat.
refactoring & comments.
resetting preview so it doesn't remember the last one when you try to submit another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Five feed worked on during CG18 retreat (with Niels, Mike and Kyle).
Adding a feature providing a way to high five someone for giving something to Umbraco community: article, help,video, PR etc. This form and feed of recent high fives is on home page when you are logged in. Only logged in users can high five.
High five submit form has a user search: type in >3 letters of the name and it will give you a drop down of matching users. Then you can select an activity type (blog post for example) then provide a link. The page will dynamically build up a preview of the high five including fetching the page title of the link.
Here is a video of the form: https://drive.google.com/file/d/1ws0SHJd5XSvLXgopApUIIHX39GSj1Uk1/view
We've also added a feed of users high fives to their profile.
Ideas for future: