https://github.com/umbraco/Umbraco-CMS/issues/16443

Also ensure master templates cannot be deleted
umbraco · Nov 15, 2024 · a75f310 · a75f310
1 parent 46f48e8
commit a75f310
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/Umbraco.Cms.Api.Management/Controllers/Template/TemplateControllerBase.cs b/src/Umbraco.Cms.Api.Management/Controllers/Template/TemplateControllerBase.cs
@@ -38,6 +38,10 @@ protected IActionResult TemplateOperationStatusResult(TemplateOperationStatus st
                 .WithTitle("Master template not found")
                 .WithDetail("The master template referenced in the template was not found.")
                 .Build()),
+            TemplateOperationStatus.MasterTemplateCannotBeDeleted => BadRequest(problemDetailsBuilder
+                .WithTitle("Master template cannot be deleted")
+                .WithDetail("The master templates cannot be deleted. Please ensure the template is not a master template before you delete.")
+                .Build()),
             _ => StatusCode(StatusCodes.Status500InternalServerError, problemDetailsBuilder
                 .WithTitle("Unknown template operation status.")
                 .Build()),

diff --git a/src/Umbraco.Core/Services/OperationStatus/TemplateOperationStatus.cs b/src/Umbraco.Core/Services/OperationStatus/TemplateOperationStatus.cs
@@ -8,5 +8,6 @@ public enum TemplateOperationStatus
     DuplicateAlias,
     TemplateNotFound,
     MasterTemplateNotFound,
-    CircularMasterTemplateReference
+    CircularMasterTemplateReference,
+    MasterTemplateCannotBeDeleted,
 }
diff --git a/src/Umbraco.Core/Services/TemplateService.cs b/src/Umbraco.Core/Services/TemplateService.cs
@@ -404,6 +404,12 @@ private void Audit(AuditType type, int userId, int objectId, string? entityType)
                 return Attempt.FailWithStatus<ITemplate?, TemplateOperationStatus>(TemplateOperationStatus.TemplateNotFound, null);
             }
 
+            if (template.IsMasterTemplate)
+            {
+                scope.Complete();
+                return Attempt.FailWithStatus<ITemplate?, TemplateOperationStatus>(TemplateOperationStatus.MasterTemplateCannotBeDeleted, null);
+            }
+
             EventMessages eventMessages = EventMessagesFactory.Get();
             var deletingNotification = new TemplateDeletingNotification(template, eventMessages);
             if (scope.Notifications.PublishCancelable(deletingNotification))