Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15: Add check for is master template #17377

Closed

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Oct 28, 2024

Notes

  • Adds validation check, to check for IsMasterTemplate.

How to test

  • Create a template
  • Create another template, and reference the first as a master template
  • Try to delete the first template, you should no longer be able to.

@bergmania
Copy link
Member

bergmania commented Nov 5, 2024

IMO this could wait for 15.1. By the end of the day, I could do that from the filesystemet/IDE anyway

@bergmania
Copy link
Member

Also, we need to ensure this do not interfere with Deploy, as the order of which templates are deleted is not important.

@Zeegaan Zeegaan closed this Nov 18, 2024
@Zeegaan
Copy link
Member Author

Zeegaan commented Nov 18, 2024

This fix was implemented in #17539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants