Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to templates: Do not allow deletion of masters and ensure file names are pascal case #17539

Do not check breaking changes in integration tests

04b23e6
Select commit
Loading
Failed to load commit list.
Merged

Fixes to templates: Do not allow deletion of masters and ensure file names are pascal case #17539

Do not check breaking changes in integration tests
04b23e6
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Nov 15, 2024 in 32s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (8.63 -> 8.63)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Code Duplication TemplateServiceTests.cs: Deleting_Master_Template_Also_Deletes_Children

Annotations

Check notice on line 1 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/TemplateServiceTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ Getting better: Code Duplication

reduced similar code in: Deleting_Master_Template_Also_Deletes_Children. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.