Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17952
There was both a functional and an architectural issue here.
Fucntionally the
IUrlProvider.GetOtherUrls
wasn't listed in the V15 backoffice, in fact, custom IUrlProviders wasn't taken into account at all.This was because a new method
IDocumentUrlService.ListUrlsAsync
was used. This does not work, becauseIDocumentUrlService
is what's used by the defaultIUrlProvider
internally, meaning that theIUrlProviders
can never be taken into account here, due to circular references, additionally this would only take into account "default" urls.To fix this I've moved the responsibility of listing urls into its own service
IPublishedUrlInfoProvider
which uses theIUrlProviders
to generate the urls. This is very simiklar to the old behaviour inGetContentUrlsAsync
. This means that the listed URLS are now aligned with how they used to be in V13.Testing
See issue for testing steps.
Additionally:
Listed urls:
Do note that /da/ is there twice, this is the same as in V13, once from "normal" urls and once from "other urls"