Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Fix Url Preview #18072

Open
wants to merge 4 commits into
base: v15/dev
Choose a base branch
from
Open

Conversation

nikolajlauridsen
Copy link
Contributor

Fixes #17952

There was both a functional and an architectural issue here.

Fucntionally the IUrlProvider.GetOtherUrls wasn't listed in the V15 backoffice, in fact, custom IUrlProviders wasn't taken into account at all.

This was because a new method IDocumentUrlService.ListUrlsAsync was used. This does not work, because IDocumentUrlService is what's used by the default IUrlProvider internally, meaning that the IUrlProviders can never be taken into account here, due to circular references, additionally this would only take into account "default" urls.

To fix this I've moved the responsibility of listing urls into its own service IPublishedUrlInfoProvider which uses the IUrlProviders to generate the urls. This is very simiklar to the old behaviour in GetContentUrlsAsync. This means that the listed URLS are now aligned with how they used to be in V13.

Testing

See issue for testing steps.

Additionally:

  1. Add an additional language
  2. Create a piece of content that does not vary by culture
  3. Configure domains (see screenshot)
  4. Create a child
  5. Ensure that they're listed in the URL overview

image

Listed urls:
image

Do note that /da/ is there twice, this is the same as in V13, once from "normal" urls and once from "other urls"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant