Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attached on destroy #2526

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/controller-api/controller-host.mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export const UmbControllerHostMixin = <T extends ClassConstructor>(superClass: T
prev = ctrl;
}
this.#controllers.length = 0;
this.#attached = false;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ export abstract class UmbBaseExtensionInitializer<
/*
public hostConnected(): void {
super.hostConnected();
// Should not be nesecary as conditions would be reactive to connectedCallback, as they will use consumeContext. [NL]
//this.#onConditionsChangedCallback();
}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export class UmbExtensionSlotElement extends UmbLitElement {
this.#observeExtensions();
}
override disconnectedCallback(): void {
// _permitted is reset as the extensionsController fires a callback on destroy.
this.#attached = false;
this.#extensionsController?.destroy();
this.#extensionsController = undefined;
Expand Down
Loading