Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Combobox not working in Safari #929

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Bugfix: Combobox not working in Safari #929

merged 1 commit into from
Oct 10, 2024

Conversation

JesmoDev
Copy link
Contributor

Fixes: #748
Fixes combobox dropdown having 0 height in safari.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev changed the title fix height issue Bugfix: Combobox not working in Safari Oct 10, 2024
@JesmoDev JesmoDev requested a review from julczka October 10, 2024 10:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-929.westeurope.azurestaticapps.net

julczka
julczka approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@julczka julczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jesper! 💯

@julczka julczka merged commit 203487c into v1/contrib Oct 10, 2024
11 of 12 checks passed
@julczka julczka deleted the v1/bugfix/combobox-safari branch October 10, 2024 11:54
@iOvergaard iOvergaard added the bug Something isn't working label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julczka julczka julczka approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUI-Combobox does not display properly in Safari
3 participants
@JesmoDev @julczka @iOvergaard