Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: solution to double selection #958

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Fix: solution to double selection #958

merged 8 commits into from
Nov 19, 2024

Conversation

nielslyngsoe
Copy link
Member

Currently there is cases where the keyboard interaction triggereds a selection but also triggers the click which then removed the selection.
This is begin fixed by this PR. which as well adds tab index for selectable components.

fixes #654

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe mentioned this pull request Nov 18, 2024
Closed
7 tasks
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 18, 2024 13:46
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-958.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit c305dfc into v1/contrib Nov 19, 2024
10 of 11 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/920 branch November 19, 2024 11:30
nielslyngsoe added a commit that referenced this pull request Nov 20, 2024
@nielslyngsoe
Fix: solution to double selection (#958)
83a5007 
* solution to double selection

* write unit test for select

* add more tests
@nielslyngsoe nielslyngsoe added the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjarnef bjarnef bjarnef left review comments

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uui-swatch: selection no longer works with space key
3 participants
@nielslyngsoe @bjarnef @madsrasmussen