Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump media card action and tag slot z-index #968

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: bump media card action and tag slot z-index #968

merged 1 commit into from
Nov 25, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 25, 2024 •
edited
Loading

Description

Problem: It is no longer possible to use the media card actions when a media item has an href:

This PR bumps the z-index for the action and tag slots

What to test

  • make sure that you can click the actions when a card has en href

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title Bugfix: bump media card action and tag slot z-index fix: bump media card action and tag slot z-index Nov 25, 2024
@madsrasmussen madsrasmussen added the bug Something isn't working label Nov 25, 2024
leekelleher
leekelleher approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, works as expected! 🚀

@leekelleher leekelleher merged commit 1715114 into v1/contrib Nov 25, 2024
9 of 11 checks passed
@leekelleher leekelleher deleted the v1/bugfix/media-card-actions-z-index branch November 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @leekelleher