Added dynamodb-fastapi backed fastq manager #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests Use json bodys over parameters where appropriate Fixed bug for rgids where + separator is used.
|
This is working, I'd like to be able to deploy this to production so that I can start populating it and testing integration with other services such as workflow services |
s3Uri now an output of the filestorage object for r1 and r2 samples
|
Let get this reviewed and push out, folks.! |
|
Waiting on #851, I'd like to add 'storageClass' as a 'computed field' to file object readsets. |
mmalenic
reviewed
Feb 5, 2025
Comment on lines
+25
to
+31
| if len(response) == 0: | ||
| # Try again with current_state=False | ||
| response = get_request_response_results(S3_LIST_ENDPOINT, { | ||
| "bucket": s3_bucket, | ||
| "key": s3_key, | ||
| "currentState": 'false' | ||
| }) |
There was a problem hiding this comment.
Non-current records might not have any data on S3, except for something like old versioned objects. Just something to keep in mind, I'm not 100% sure if this is being used to presign URLs eventually.
mmalenic
approved these changes
Feb 5, 2025
|
Thanks for code walkthrough / demo today, Alexis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastq Manager using FastAPI and Dyntastic as backends.
Uses lambdas to communicate between the file manager and the metadata manager when required.