Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(SRM): replace 'instrument_run_id' with 'id' for unique identifier #885

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix(SRM): replace 'instrument_run_id' with 'id' for unique identifier #885

wants to merge 13 commits into from

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Mar 3, 2025

Solve: #884

  1. For each 'bssh run', 'run id' is the unique identifier rather than 'instrument_run_id'. Reason explian in 884
  2. update the service to handle new changes and also the test cases

@raylrui raylrui added bug Something isn't working fix migration Related to data migration labels Mar 3, 2025
@raylrui raylrui self-assigned this Mar 3, 2025
@raylrui raylrui changed the title Fix(SRM)/replace 'instrument_run_id' with 'id' for unique identifier Fix(SRM): replace 'instrument_run_id' with 'id' for unique identifier Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raylrui raylrui

Labels
bug Something isn't working fix migration Related to data migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raylrui