feat: tab.action&tab.extra #1339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
reviewed
Nov 30, 2022
docs/guide/page-tab.md
Outdated
Comment on lines
35
to
36
| extra: require.resolve('./extra.tsx'), | ||
| action: require.resolve('./actions.tsx'), |
There was a problem hiding this comment.
TODO 里没说清楚…其实设想中这两个不是单独的组件，是 Tab 组件的 member exports，类型定义在这里：
dumi/src/client/theme-api/types.ts
Lines 111 to 115 in 560c4d4
feat: Tab component Extra & Action fix: remove useless code fix: remove useless code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
ContentTabs 支持识别 Tab 上的子组件，
📝 更新日志 / Changelog