fix: fetch the tags and push each one individually #195
Conversation
🦋 Changeset detectedLatest commit: d538594 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I've published a package and tested on our use case, |
|
@JounQin could you please take a look? 🙏 |
| @@ -113,6 +117,11 @@ export async function runPublish({ | |||
|
|
|||
| if (match) { | |||
| releasedPackages.push(pkg) | |||
| if (!pushAllTags) { | |||
| await gitUtils.pushTag( | |||
| `${pkg.packageJson.name}@${pkg.packageJson.version}`, | |||
There was a problem hiding this comment.
The tag should be only vx.y.z for one package. See also
And we can actually leave to use pushAllTags because there is only one.
| @@ -30,6 +30,11 @@ export const pushTags = async () => { | |||
| await exec('git', ['push', 'origin', '--tags']) | |||
| } | |||
|
|
|||
| export const pushTag = async (tag: string) => { | |||
| console.log('Pushing tag: ' + tag) | |||
There was a problem hiding this comment.
| console.log('Pushing tag: ' + tag) |
| @@ -142,6 +151,13 @@ export async function runPublish({ | |||
| } | |||
| releasedPackages.push(pkg) | |||
| } | |||
| if (!pushAllTags) { | |||
| for (const pkg of releasedPackages) { | |||
|
Sorry I didn't notice this PR previously, just raised some reviews. |
This is to bypass the limitation of gitlab
Fix #194