Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades translation-helps-rcl to 3.5.13 #594

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

theNerd247
Copy link
Contributor

@theNerd247 theNerd247 commented Nov 27, 2023

This fixes #547, #551

Testing instructions:

Resource Card Merge Button Shows No False Conflicts
  • login to the app
  • edit a resource card
  • save the change
  • ensure that the merge button show no red dot
  • perform the previous two steps a few times
Global Merge Button Still Works
  • after the previous testing stage, perform a global merge

@theNerd247 theNerd247 requested a review from kintsoogi November 27, 2023 14:41
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f85dc07) 51.71% compared to head (5b63b05) 52.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #594      +/-   ##
===========================================
+ Coverage    51.71%   52.01%   +0.29%     
===========================================
  Files           43       43              
  Lines         1338     1338              
===========================================
+ Hits           692      696       +4     
+ Misses         646      642       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theNerd247 theNerd247 self-assigned this Nov 27, 2023
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the merging with a few different files and this seems to fix it!
Good work!

@theNerd247 theNerd247 merged commit f39feac into develop Nov 27, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the translation-helps-update branch November 27, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to merge ULT in some cases
2 participants