Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version of translation-helps-rcl #603

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

kintsoogi
Copy link
Contributor

@kintsoogi kintsoogi commented Nov 29, 2023

Describe what your pull request addresses

  • Addreses fix for Gateway Edit #601
  • Change setItem to only pass in null to setCurrentCheck if needed values are not string (will be undefined if not present in items)

Test Instructions

  • Open Deploy Preview
  • Navigate to Habakkuk in unfoldingWord org (some other books did not show the same problem. The race condition did not affect smaller books)
  • Add a new TN that has a reference range (i.e 1:1-3)
    • Navigate to the newly created note.
    • Verify that the scripture card panes are showing the verses for the reference range that was input. For example, if you input a reference range of 1:1-3, you should see all three verses in the scripture cards

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa43758) 51.64% compared to head (548dd8f) 52.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #603      +/-   ##
===========================================
+ Coverage    51.64%   52.02%   +0.37%     
===========================================
  Files           43       43              
  Lines         1336     1336              
===========================================
+ Hits           690      695       +5     
+ Misses         646      641       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kintsoogi kintsoogi force-pushed the kintsoogi-601-refRangeNotShown branch from 3e732c1 to 548dd8f Compare November 30, 2023 15:54
Fixes bug where reference was not updating correctly for reference range
@kintsoogi kintsoogi requested a review from theNerd247 November 30, 2023 15:55
@kintsoogi kintsoogi marked this pull request as ready for review November 30, 2023 15:55
@kintsoogi kintsoogi merged commit 548dd8f into develop Nov 30, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the kintsoogi-601-refRangeNotShown branch November 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants