Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripture-tsv library for deleting reference ranges (#593) #609

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

kintsoogi
Copy link
Contributor

@kintsoogi kintsoogi commented Dec 4, 2023

Describe what your pull request addresses

  • Provide the ability to delete a reference range within a TSV resource.

Test Instructions

  • Open Deploy Preview
  • In a valid TSV resource (TN is easiest to see), create a new TSV item with a reference range (i.e 1:1-4 OR 1:1;3:2).
    • Navigate to another verse within your reference range to verify that your TSV item shows at that reference.
  • In any of the verses within the reference range you created, delete the new item with the reference range.
    • Navigate to another verse within your reference range to verify that your TSV item DOES NOT SHOW at that reference.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (548dd8f) 52.02% compared to head (b3e8c68) 51.64%.

Files Patch % Lines
src/components/ResourceCard.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #609      +/-   ##
===========================================
- Coverage    52.02%   51.64%   -0.38%     
===========================================
  Files           43       43              
  Lines         1336     1336              
===========================================
- Hits           695      690       -5     
- Misses         641      646       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kintsoogi kintsoogi force-pushed the kintsoogi-593-deleteRefRange branch from 5732922 to b3e8c68 Compare December 5, 2023 00:34
@kintsoogi kintsoogi marked this pull request as ready for review December 5, 2023 00:35
@kintsoogi kintsoogi requested a review from PhotoNomad0 December 5, 2023 01:41
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhotoNomad0 PhotoNomad0 merged commit 24d3931 into develop Dec 5, 2023
7 of 9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the kintsoogi-593-deleteRefRange branch December 5, 2023 10:37
theNerd247 pushed a commit that referenced this pull request Dec 6, 2023
* Fix item index not incrementing on adding at first item

* Update version of scripture-tsv to 0.4.0
PhotoNomad0 pushed a commit that referenced this pull request Dec 6, 2023
* Fix item index not incrementing on adding at first item

* Update version of scripture-tsv to 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants