Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 526 / fix slow text edit behavior #618

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Dec 18, 2023

Describe what your pull request addresses

  • update single-scripture-rcl with fix for slow verse edit behavior

Test Instructions

  • test with https://deploy-preview-618--gateway-edit.netlify.app/
  • edit a verse and paste in a large text block
  • then type some more characters and should not see any delays for characters typed in.
  • when you are editing, you should see the save and align buttons grayed out. If you try clicking on them, you should only see the processing spinner as edit window loses context. You should not see saving of verse changes or alignment dialog pop up - just the processing spinner.
  • when you leave text edit window, should see spinner when processing new edit text
  • after processing finished, save and alignment button should be re-enabled.

@PhotoNomad0 PhotoNomad0 changed the title bugfix 526 / fix slow text edit behavior WIP: bugfix 526 / fix slow text edit behavior Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9a318b) 50.11% compared to head (bb60903) 51.89%.

❗ Current head bb60903 differs from pull request most recent head a2de80a. Consider uploading reports for the commit a2de80a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
+ Coverage    50.11%   51.89%   +1.78%     
===========================================
  Files           43       43              
  Lines         1345     1345              
===========================================
+ Hits           674      698      +24     
+ Misses         671      647      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhotoNomad0
Copy link
Contributor Author

Note:

  • the longest part of the delays is coming from wordaligner.merge() which merges verse alignments and wordbank with the verse text. This is in an old library used with tCore that is used during export to usfm. It would be touchy to modify due to the risk of breaking tCore also. We have a bunch of unit tests, but not known if all edge cases covered.

@PhotoNomad0 PhotoNomad0 force-pushed the bugfix-mcleanb-526-editLags branch from 1e53c7e to bb60903 Compare December 20, 2023 20:14
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review December 20, 2023 20:19
@PhotoNomad0 PhotoNomad0 changed the title WIP: bugfix 526 / fix slow text edit behavior Bugfix 526 / fix slow text edit behavior Dec 20, 2023
@PhotoNomad0 PhotoNomad0 merged commit 0eda053 into develop Dec 20, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-mcleanb-526-editLags branch December 20, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant