Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency scripture-resources-rcl #671

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Jan 14, 2025

Describe what your pull request addresses

This updates scripture-resources-rcl dependency, which fixes bug with finding quotes occurrences for highlighting. When the occurrence is set to +1 and the requested quotes is a group of quotes separated by ampersand.
New behavior: finds the requested occurrence of the first quote and looks for the next first matching occurring of the rest of the quotes (the quotes after the first ampersand).

Test Instructions

  • [ ]

@abelpz abelpz requested a review from richmahn January 14, 2025 20:36
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richmahn richmahn merged commit a41f97f into develop Feb 3, 2025
6 of 8 checks passed
@richmahn richmahn deleted the abelpz-update-dep-scripture-resources-rcl branch February 3, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants