Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate PRs to be created #1658

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Jan 27, 2025

Describe what your pull request addresses (Please include relevant issue numbers):

Problem:
Issue #1654 reported duplicate PR creations, likely caused by server bottleneck when multiple branch-merger requests are processed simultaneously.

Solution:

  • Implemented a queue system to manage branch-merger requests
  • Added configurable time interval between PR creation requests
  • Prevents request flooding by ensuring sequential processing

Technical Details:

  • Requests are now processed sequentially through a queue
  • Each request waits for a predefined interval before processing
  • Reduces server load and minimizes risk of duplicate PR creation

Testing:
While the original issue couldn't be consistently replicated, this solution addresses the suspected root cause by preventing concurrent PR creation requests.

Related:
Fixes #1654

Please include detailed Test instructions for your pull request:

  • No reproduce-able steps given.

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

@abelpz abelpz changed the title add a queue system for branch-merger requests Prevent duplicate PRs to be created Jan 27, 2025
@abelpz abelpz merged commit 869c23f into develop Feb 4, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of duplicate PR on tcCreate
1 participant