Improved poll creation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about the unregister app poll_started signal litsner? doesn't it require the locked stuff? |
|
Nope. It doesn't do anything until the messages are in "P" status. On Mon, Jan 16, 2012 at 10:33 AM, Mugisha Moses <
|
|
ahh you do it message.masstext .. ok will go ahead and pull it in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's actually no reason to ever create the messages in "locked" status anyway, this is a relic of one of the older ways we were creating polls.
Now the bulk sql work is almost equally split between "create_with_bulk" and "start"...it's moving fairly quickly on my local machine, but of course that's no guarantee it'll be fast enough to work on production. But, it's a step in the right direction...