ReIndev Support #80
Merged
ReIndev Support #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halotroop2288
force-pushed
the
pr/foxloader
branch
4 times, most recently
from
4bb1b69 to
9396f7e
Compare
halotroop2288
commented
Jul 25, 2024
src/api/kotlin/xyz/wagyourtail/unimined/api/minecraft/patch/reindev/ReIndevPatcher.kt
Outdated
Show resolved
Hide resolved
...n/xyz/wagyourtail/unimined/internal/minecraft/patch/reindev/NoTransformReIndevTransformer.kt
Outdated
Show resolved
Hide resolved
...n/xyz/wagyourtail/unimined/internal/minecraft/patch/reindev/NoTransformReIndevTransformer.kt
Outdated
Show resolved
Hide resolved
halotroop2288
force-pushed
the
pr/foxloader
branch
7 times, most recently
from
4a05ffd to
f6c0f75
Compare
halotroop2288
commented
Jul 26, 2024
| override val minecrafts = defaultedMapOf<SourceSet, MinecraftConfig> { | ||
| MinecraftProvider(project, it) | ||
| } | ||
| override val minecrafts = mutableMapOf<SourceSet, MinecraftConfig>() |
There was a problem hiding this comment.
This may be a point of contention, but it was necessary to make this work.
Let me know what you think!
halotroop2288
commented
Jul 26, 2024
src/main/kotlin/xyz/wagyourtail/unimined/UniminedExtensionImpl.kt
Outdated
Show resolved
Hide resolved
thecatcore
reviewed
Jul 26, 2024
src/api/kotlin/xyz/wagyourtail/unimined/api/UniminedExtension.kt
Outdated
Show resolved
Hide resolved
src/api/kotlin/xyz/wagyourtail/unimined/api/UniminedExtension.kt
Outdated
Show resolved
Hide resolved
src/api/kotlin/xyz/wagyourtail/unimined/api/UniminedExtension.kt
Outdated
Show resolved
Hide resolved
halotroop2288
force-pushed
the
pr/foxloader
branch
from
f6c0f75 to
cbf9a53
Compare
|
I'm ready to change FoxLoader for this project need if needed. Reference: https://github.com/Fox2Code/FoxLoader FoxLoader has some transformers applied on top of the base ReIndev game like what NeoForged does. |
halotroop2288
force-pushed
the
pr/foxloader
branch
from
cbf9a53 to
c554330
Compare
halotroop2288
force-pushed
the
pr/foxloader
branch
from
c554330 to
606f113
Compare
halotroop2288
force-pushed
the
pr/foxloader
branch
from
606f113 to
e096460
Compare
halotroop2288
commented
Jul 26, 2024
...n/xyz/wagyourtail/unimined/internal/minecraft/patch/fabric/FabricLikeMinecraftTransformer.kt
Outdated
Show resolved
Hide resolved
halotroop2288
commented
Jul 26, 2024
| "ReIndev-none" | ||
| ) { | ||
|
|
||
| override var prodNamespace: MappingNamespaceTree.Namespace = provider.mappings.OFFICIAL |
There was a problem hiding this comment.
This actually does nothing, the same way it does nothing in NoTransformMinecraftTransformer. The value is already set to this in the super class.
cc: @wagyourtail
Extends MinecraftProvider and provides ReIndev jars from cdn.Fox2Code.com
halotroop2288
force-pushed
the
pr/foxloader
branch
from
e096460 to
9ae2990
Compare
halotroop2288
force-pushed
the
pr/foxloader
branch
from
2904d41 to
dd215d9
Compare
|
I've just realized, shouldn't prs target |
it depends |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReIndevProviderto enable getting the Minecraft: ReIndev jar as a Minecraft jar.To-do
AddNoTransformReIndevTransformerfor ReIndev jar moddingReplaced with
ReIndevProviderFoxLoaderReIndevTransformerfor FoxLoader moddingWill do in a later PR