Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up aquapointer docs #39

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Set up aquapointer docs #39

merged 14 commits into from
Apr 23, 2024

Conversation

Misty-W
Copy link
Contributor

@Misty-W Misty-W commented Feb 20, 2024

Fixes #4

  • Add files generated from Sphinx quickstart
  • Create apidoc.rst
  • Setup Read the Docs

@Misty-W
Copy link
Contributor Author

Misty-W commented Feb 20, 2024

@FarLab and @nathanshammah I started this PR for the initial documentation setup.

✅ I can get minimal docs to build locally --> looks like the Sphinx quickstart worked.
❌ Haven't yet figured out what's causing the warnings on each entry in the API-doc,

WARNING: autodoc: failed to import module 'aquapointer'; the following exception was raised:
No module named 'aquapointer.analog'

I'll come back to this after I try the RTD setup flow.

@Misty-W
Copy link
Contributor Author

Misty-W commented Feb 20, 2024

Also set up https://readthedocs.org/projects/aquapointer/ and added a .readthedocs.yaml file.
@nathanshammah I added you as a maintainer on RTD.
@FarLab, can you create a Read the Docs (RTD) account connected with your GitHub account? Then I can add you as a maintainer.
RTD is failing even after the addition of the associated yaml- maybe I missed modifying something in the template, or maybe something is off about conf.py.

@FarLab
Copy link
Contributor

FarLab commented Feb 23, 2024

@Misty-W Just created a RTD account (username: farlab) and connected it with my github account!

@Misty-W
Copy link
Contributor Author

Misty-W commented Mar 13, 2024

Functions are showing up in API-doc now 🥳 . Rendering could be better- maybe a similar styling to what we have in Mitiq would be nice.

Also, I'm almost certain the RTD failure is due to RTD looking at main which of course doesn't have an RTD yaml file, whereas this PR does. Should "fix itself" upon merging. Eventually might want to preview RTD on PRs but that could probably wait in favor of other

@nathanshammah
Copy link
Member

Great @Misty-W! I still cannot generate them with sphinx-build -b html source build. Is this what you're using?

@Misty-W
Copy link
Contributor Author

Misty-W commented Mar 20, 2024

Great @Misty-W! I still cannot generate them with sphinx-build -b html source build. Is this what you're using?

@nathanshammah I'm using make html.

@nathanshammah
Copy link
Member

Mmh, strange, I get this message, even if I installed aquapointer with pip install -e . (v.0.0.2):

WARNING: Failed to import aquapointer.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.analog.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.analog.analog.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.analog.density_mapping.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.analog.qubo_solution.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.analog_digital.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.digital.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
WARNING: Failed to import aquapointer.slicing.
Possible hints:
* KeyError: 'aquapointer'
* ModuleNotFoundError: No module named 'scipy'
building [mo]: targets for 0 po files that are out of date
writing output...
building [html]: targets for 0 source files that are out of date
updating environment: 0 added, 1 changed, 0 removed
reading sources... [100%] apidoc
WARNING: autodoc: failed to import module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'analog' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'analog.analog' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'analog.density_mapping' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'analog.qubo_solution' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'analog_digital' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'digital' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import module 'slicing' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import class 'density_canvas' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'
WARNING: autodoc: failed to import class 'analog_digital.processor' from module 'aquapointer'; the following exception was raised:
No module named 'scipy'

@Misty-W
Copy link
Contributor Author

Misty-W commented Mar 21, 2024

@nathanshammah I think pip install -e ".[development]" based on my testing with @FarLab running pip install requirements.txt should resolve the environment issues.

@FarLab, are you able to build and open the docs from this branch locally?

@Misty-W Misty-W marked this pull request as ready for review April 23, 2024 02:32
@Misty-W Misty-W requested a review from FarLab April 23, 2024 02:32
Copy link
Contributor

@FarLab FarLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarLab FarLab merged commit ed7ab73 into main Apr 23, 2024
2 checks passed
@FarLab FarLab deleted the aquapointer-docs-setup branch April 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation
3 participants