Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate DensityCanvas into slicing utility #49

Merged
merged 14 commits into from
Apr 4, 2024
Merged

Conversation

Misty-W
Copy link
Contributor

@Misty-W Misty-W commented Mar 21, 2024

  • Add ability to rotate slice to match corresponding midplane (between slicing planes, where slices "live" in 3DRISM coordinates
  • Output slices as DensityCanvas
  • Find a suitable place for cropping

Misty-W added 5 commits March 11, 2024 12:36
Fix cropping bug and update interface to work better with `DensityCanvas`

Clean up slicing demo notebook
@Misty-W
Copy link
Contributor Author

Misty-W commented Mar 21, 2024

@FarLab I fixed the cropping function on this branch.

Eventually all slicing functions will output DensityCanvas but right now, cropping works correctly with arrays.

@Misty-W Misty-W marked this pull request as draft March 22, 2024 06:23
@Misty-W Misty-W marked this pull request as ready for review April 4, 2024 12:50
@Misty-W Misty-W requested a review from FarLab April 4, 2024 12:50
@FarLab FarLab merged commit 35e64db into main Apr 4, 2024
2 checks passed
@Misty-W Misty-W deleted the integrate-density-canvas branch April 4, 2024 13:02
@Misty-W Misty-W restored the integrate-density-canvas branch April 4, 2024 14:04
@Misty-W Misty-W deleted the integrate-density-canvas branch May 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants