Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Added Garnet Testnet #14786

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

blurpesec
Copy link
Contributor

Description

Adds Garnet Testnet support (full support pending support by TheGraph).

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

Copy link

cla-bot bot commented Oct 1, 2024

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @blurpesec on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@julien51
Copy link
Member

julien51 commented Oct 1, 2024

Thanks @blurpesec ! @clemsos will look into that ASAP. Can you send a bit of test eth to clemsos.eth and hot.julien51.eth by chance?

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
@unlock-deployer
Copy link
Collaborator

Error: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)
at makeError (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:694:21)
at assert (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:715:25)
at Interface.decodeFunctionResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/abi/interface.ts:916:15)
at staticCallResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:346:35)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async staticCall (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:303:24)
at async Proxy.publicLockLatestVersion (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:351:41)
at async getTemplateAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:78:23)
at async getAllAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:17:5)
at async run (/home/runner/work/unlock/unlock/packages/networks/bin/validate.ts:53:23) {
code: 'BAD_DATA',
value: '0x',
info: {
method: 'publicLockLatestVersion',
signature: 'publicLockLatestVersion()'
},
shortMessage: 'could not decode result data'
}
Could not process the file: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)

@blurpesec
Copy link
Contributor Author

blurpesec commented Oct 1, 2024

Thanks @blurpesec ! @clemsos will look into that ASAP. Can you send a bit of test eth to clemsos.eth and hot.julien51.eth by chance?

@julien51 sent

@unlock-deployer
Copy link
Collaborator

Error: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)
at makeError (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:694:21)
at assert (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:715:25)
at Interface.decodeFunctionResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/abi/interface.ts:916:15)
at staticCallResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:346:35)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async staticCall (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:303:24)
at async Proxy.publicLockLatestVersion (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:351:41)
at async getTemplateAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:78:23)
at async getAllAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:17:5)
at async run (/home/runner/work/unlock/unlock/packages/networks/bin/validate.ts:53:23) {
code: 'BAD_DATA',
value: '0x',
info: {
method: 'publicLockLatestVersion',
signature: 'publicLockLatestVersion()'
},
shortMessage: 'could not decode result data'
}
Could not process the file: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)

symbol: 'EVE',
},
],
unlockAddress: '0x1bc53f4303c711cc693F6Ec3477B83703DcB317f',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
featured: true,
id: 17069,
isTestNetwork: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, our policy is usually to not support more testnets that we already have (Sepolia and Base Sepolia). These can be added but we won't support the infra to deploy locks etc. @julien51 can confirm maybe ?

Copy link
Contributor Author

@blurpesec blurpesec Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be added but we won't support the infra to deploy locks etc

What exactly is required here ? Is this something that requires TheGraph? Or do you have some infra built on top of it that you would have to maintain ?

@unlock-deployer
Copy link
Collaborator

Error: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)
at makeError (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:694:21)
at assert (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:715:25)
at Interface.decodeFunctionResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/abi/interface.ts:916:15)
at staticCallResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:346:35)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async staticCall (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:303:24)
at async Proxy.publicLockLatestVersion (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:351:41)
at async getTemplateAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:78:23)
at async getAllAddresses (/home/runner/work/unlock/unlock/packages/networks/bin/utils/contracts.ts:17:5)
at async run (/home/runner/work/unlock/unlock/packages/networks/bin/validate.ts:53:23) {
code: 'BAD_DATA',
value: '0x',
info: {
method: 'publicLockLatestVersion',
signature: 'publicLockLatestVersion()'
},
shortMessage: 'could not decode result data'
}
Could not process the file: could not decode result data (value="0x", info={ "method": "publicLockLatestVersion", "signature": "publicLockLatestVersion()" }, code=BAD_DATA, version=6.13.2)

@unlock-deployer
Copy link
Collaborator

TypeError: bad address checksum (argument="address", value="0x839fdccb5bf005cbdd84dd2700fbd9B64bd94772", code=INVALID_ARGUMENT, version=6.13.2)
at makeError (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:687:21)
at assert (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:715:25)
at assertArgument (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/utils/errors.ts:727:5)
at getAddress (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/address/address.ts:131:23)
at resolveAddress (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/address/checks.ts:108:67)
at (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/providers/abstract-provider.ts:832:40)
at Array.forEach ()
at JsonRpcProvider._getTransactionRequest (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/providers/abstract-provider.ts:829:26)
at JsonRpcProvider.call (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/providers/abstract-provider.ts:1041:22)
at staticCallResult (/home/runner/work/unlock/unlock/node_modules/ethers/src.ts/contract/contract.ts:337:35) {
code: 'INVALID_ARGUMENT',
argument: 'address',
value: '0x839fdccb5bf005cbdd84dd2700fbd9B64bd94772',
shortMessage: 'bad address checksum'
}
Could not process the file: bad address checksum (argument="address", value="0x839fdccb5bf005cbdd84dd2700fbd9B64bd94772", code=INVALID_ARGUMENT, version=6.13.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants