Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lightweight styling to TextBox #1049

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat: add lightweight styling to TextBox #1049

merged 2 commits into from
Sep 28, 2023

Conversation

Arieldelossantos
Copy link
Contributor

@Arieldelossantos Arieldelossantos commented Jul 11, 2023 •
edited
Loading

GitHub Issue: unoplatform/uno.themes-private#12

PR Type

What kind of change does this PR introduce?

  • Feature

Description

add lightweight styling TextBox

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@Arieldelossantos Arieldelossantos self-assigned this Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 5e7ba4f to feda93a Compare July 12, 2023 15:08
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos changed the title feat: add lightweight styling to CSharpMarkup TextBox feat: add lightweight styling to TextBox Jul 13, 2023
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from feda93a to 10c1bbb Compare July 13, 2023 21:18
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch 2 times, most recently from d006400 to 57fb090 Compare July 20, 2023 20:50
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 57fb090 to 38b87d5 Compare July 21, 2023 15:49
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 38b87d5 to 752476a Compare July 21, 2023 15:56
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 752476a to c845119 Compare July 24, 2023 17:22
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@carlh98 carlh98 requested review from Xiaoy312 and kazo0 July 26, 2023 18:28
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from c845119 to 4960dc6 Compare July 31, 2023 14:46
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@agneszitte agneszitte marked this pull request as draft August 11, 2023 16:12
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 4960dc6 to a57b53c Compare September 19, 2023 18:38
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from a57b53c to 9e8865f Compare September 19, 2023 20:07
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@Arieldelossantos Arieldelossantos marked this pull request as ready for review September 19, 2023 20:17
kazo0
kazo0 reviewed Sep 25, 2023
View reviewed changes
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Outdated Show resolved Hide resolved
src/library/Uno.Themes.WinUI.Markup/Theme/TextBox.cs Show resolved Hide resolved
@kazo0 kazo0 force-pushed the dev/arde/csharp-markup-lightweight-styling-textbox branch from 9e8865f to 920d296 Compare September 28, 2023 15:57
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) September 28, 2023 16:44
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1049.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit a747432 into master Sep 28, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/arde/csharp-markup-lightweight-styling-textbox branch September 28, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@Arieldelossantos Arieldelossantos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arieldelossantos @kazo0 @agneszitte